-
Notifications
You must be signed in to change notification settings - Fork 15
feat(utils): add file sink classes #1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit e0c210e
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 8cc3cbb with previous commit 270b474. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 3 groups regressed, 👍 1 audit improved, 👎 9 audits regressed, 17 audits changed without impacting score🗃️ Groups
31 other groups are unchanged. 🛡️ Audits
652 other audits are unchanged. |
# Conflicts: # packages/utils/src/lib/sink-source.types.ts
# Conflicts: # testing/test-utils/src/lib/utils/perf-hooks.mock.ts
Code PushUp😟 Code PushUp report has regressed – compared current commit 8cc3cbb with previous commit 270b474. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🔴 45 | 🔴 37 | |
| Code coverage | 🟢 95 | 🟢 94 |
4 other categories are unchanged.
👎 2 groups regressed, 👎 8 audits regressed, 1 audit changed without impacting score
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🔴 45 | 🔴 37 | |
| Code coverage | Code coverage metrics | 🟢 95 | 🟢 94 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Methods coverage | 🟨 13 undocumented methods | 🟥 40 undocumented methods | |
| JSDocs coverage | Classes coverage | 🟨 3 undocumented classes | 🟥 7 undocumented classes | |
| Code coverage | Function coverage | 🟩 96.2 % | 🟩 94.1 % | |
| JSDocs coverage | Variables coverage | 🟥 49 undocumented variables | 🟥 55 undocumented variables | |
| JSDocs coverage | Types coverage | 🟥 66 undocumented types | 🟥 70 undocumented types | |
| Code coverage | Branch coverage | 🟩 91.8 % | 🟩 91.1 % | |
| Code coverage | Line coverage | 🟩 97.8 % | 🟩 97.2 % | |
| JSDocs coverage | Functions coverage | 🟥 239 undocumented functions | 🟥 246 undocumented functions | |
| JSDocs coverage | Properties coverage | 🟥 27 undocumented properties | 🟥 36 undocumented properties |
435 other audits are unchanged.
13 other projects are unchanged.
Related: #1197
This PR includes:
file-sinksink classfile-sink-jsonlsink classfile-sink-trace-jsonsink class